Merged
Conversation
evilpie
force-pushed
the
assert-is-valid
branch
from
5efb213 to
483a9ca
Compare
annevk
approved these changes
Oct 31, 2025
Collaborator
Author
|
Ah, I forgot about remove unsafe. |
evilpie
force-pushed
the
assert-is-valid
branch
from
483a9ca to
a46e536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserting that the config is valid basically verifies all properties we want for #323. I do think for dataAttributes at least we might want to add some additional asserts to make it even more explicit.
Preview | Diff