Conversation
| <h4><dfn data-idl id="dfn-TurboShakeParams">TurboShakeParams</dfn> dictionary</h4> | ||
| <pre class=idl> | ||
| dictionary TurboShakeParams : Algorithm { | ||
| required [EnforceRange] unsigned long length; |
There was a problem hiding this comment.
I know I did the same for cSHAKE, but while reviewing this I realized that for the other algorithms in Web Crypto that have a length parameter (AES and HMAC), it refers to the length of the key, rather than the length of the output. Obviously here there's no key so it may be obvious what it means, but maybe it's still clearer to name this outputLength (for TurboShake, KangarooTwelve and cSHAKE)?
There was a problem hiding this comment.
Obviously here there's no key so it may be obvious what it means, but maybe it's still clearer to name this
outputLength(for TurboShake, KangarooTwelve and cSHAKE)?
Sure, that's better. I'll align this one after cSHAKE gets changed.
There was a problem hiding this comment.
Yeah, good catch. For KMAC there's an even stronger argument to renaming it because it has a key length parameter (for generation) too. I've made a PR in #52.
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
3 participants
refs #31
cc @emanjon
Preview | Diff