fix(spec): make bubbling clearer for onmonetization
#458
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
sidvishnoi marked as non substantive for IPR from ash-nazg. |
|
Won't somebody think of the grandchildren?
…On Tue, 18 June 2024, 5:21 pm W3C Bot, ***@***.***> wrote:
sidvishnoi <https://github.com/sidvishnoi> marked as non substantive for
IPR from ash-nazg.
—
Reply to this email directly, view it on GitHub
<#458 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAHG4PFGAFG4ZPMGOGVUDZIAC3HAVCNFSM6AAAAABJPXDWVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVG42DMMZXGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Was adding |
|
Oh I need to generate specification manually? It's not in deploy preview. |
|
Won't somebody think of the respec job?
…On Tue, 18 June 2024, 5:25 pm Sid Vishnoi, ***@***.***> wrote:
Oh I need to generate specification manually? It's not in deploy preview.
—
Reply to this email directly, view it on GitHub
<#458 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAHG4KT5B5D2B5AOYXZS3ZIADJPAVCNFSM6AAAAABJPXDWVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVG42TIOJYHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I don't like adding that file to commit log. I'll do the CI first. |
This reverts commit 08b5703.
BGAK2024
approved these changes
Feb 24, 2025
|
Once upon a time
…On Mon, 24 Feb 2025, 8:26 am BGAK2024, ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#458 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAHG4PMT6D4UOTGZXKEHL2RJYN7AVCNFSM6AAAAABXW5ETKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZVHA4DAMBZGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed duplicate content in head.