-
Notifications
You must be signed in to change notification settings - Fork 160
Remove Umami event attributes from site links, add the ones bibi wanted #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,6 @@ const cardList: Plugin[] = [...cards.slice(0, 3)] | |
| <a | ||
| href={card.cta.href} | ||
| class='btn flexible secondary' | ||
| data-umami-event={card.cta.event} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should also remove the
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And, in general, we should remove this property everywhere else it’s no longer being used. |
||
| target='_blank' | ||
| rel='noreferrer noopener' | ||
| > | ||
|
|
@@ -50,7 +49,6 @@ const cardList: Plugin[] = [...cards.slice(0, 3)] | |
| <a | ||
| href={libraryUrl} | ||
| class='btn flexible primary' | ||
| data-umami-event='Developers page - Full plugin list' | ||
| target='_blank' | ||
| rel='noreferrer noopener' | ||
| > | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would have thought we would be interest in wallet list clicks, especially for the Interledger app wallet. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,9 +37,7 @@ const t = useTranslations(lang) | |
| Web Monetization connects publishers, creators and their audiences, | ||
| turning engagement into revenue. No friction, no barriers, no limits. | ||
| </p> | ||
| <a | ||
| class='btn primary flexible hero-btn' | ||
| href='#start' | ||
| <a class='btn primary flexible hero-btn' href='#start' | ||
| >Get started today</a | ||
| > | ||
| </div> | ||
|
|
@@ -87,7 +85,6 @@ const t = useTranslations(lang) | |
| href='https://github.com/WICG/webmonetization/pulls' | ||
| target='_blank' | ||
| rel='noreferrer noopener' | ||
| data-umami-event='Home page link - GitHub PR' | ||
| class='bold'>Do you know other wallets? Make a PR</a | ||
| > | ||
| </div> | ||
|
|
@@ -126,7 +123,6 @@ const t = useTranslations(lang) | |
| <a | ||
| class='btn primary flexible' | ||
| href='/publishers' | ||
| data-umami-event='Home page link - Publishers' | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are also primary CTAs, why would we not care about them being clicked? |
||
| >Start earning today</a | ||
| > | ||
| </div> | ||
|
|
@@ -165,7 +161,6 @@ const t = useTranslations(lang) | |
| <a | ||
| class='btn primary flexible' | ||
| href='/supporters' | ||
| data-umami-event='Home page link - Supporters' | ||
| >Support on your terms</a | ||
| > | ||
| </div> | ||
|
|
@@ -178,10 +173,8 @@ const t = useTranslations(lang) | |
| <h2>I'm a developer</h2> | ||
| <p class='audience-desc font-h6'>and I want to pay the web forward</p> | ||
| <PillTag pills={developerTags} /> | ||
| <a | ||
| class='btn primary flexible' | ||
| href='/developers' | ||
| data-umami-event='Home page link - Developers'>Join the community</a | ||
| <a class='btn primary flexible' href='/developers' | ||
| >Join the community</a | ||
| > | ||
| </div> | ||
| <div class='developer-images'> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that we'd remove event tracking for the primary audience CTAs.