-
Notifications
You must be signed in to change notification settings - Fork 160
Add ESLint and Prettier config #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
JonathanMatthey
commented
Nov 28, 2025
- Adds ESLint and Prettier configuration mirrored from the paymentpointers.org repo:
- eslint.config.js with TypeScript, Astro, and Prettier integration
- Updated .prettierrc and .prettierignore
- format and lint scripts in package.json
- CI workflow to run lint on push/PR to main
- Fixed existing lint errors across the codebase
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Anca Matei <[email protected]>
# Conflicts: # astro.config.mjs # src/content/docs/developers/tools.mdx # src/content/docs/docs.mdx # src/content/docs/supporters/get-started.mdx # src/data/publishers.ts # src/layouts/Base.astro
|
i've done a manual side by side comparison of every doc page... fixed everything... tehre's still some linting issues and conflicts, resolving those now and we should be good |
|
Ready for Review ! :) @JoblersTune @Anca2022 |
435457c to
2fd2ae0
Compare
Anca2022
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatter and the linter work as expected :D
Some minor changes need to be made before merging
| 5. Click **Accept** on the Interledger request screen. | ||
| 1. Sign in to your <LinkOut href="https://wallet.interledger-test.dev/">wallet account</LinkOut>. | ||
| 2. Download and install Interledger Foundation's [Web Monetization browser extension](/supporters/get-started#install-the-extension). | ||
| 3. Enter the payment pointer associated with your test wallet. For example, `$ilp.interledger-test.dev/mytestwallet`. Then, enter a budget amount and click **Connect**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following line used to be in the code and is nowmissing:
<br /><img src='/img/docs/extension/connection-setup.png' alt='Extension setup screen with wallet address and amount fields, renew monthly toggle, and connect button' style='max-width:300px' class='img-outline'/>
| alt="Extension setup screen with wallet address and amount fields, renew monthly toggle, and connect button" | ||
| style="max-width:300px" | ||
| class="img-outline" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This img is afterstep 3 - I think it got misplaced while formatting
| style="max-width:300px" | ||
| class="img-outline" | ||
| /> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this image: it comes after step 2 , inside <Steps>
| <img | ||
| src="/img/docs/extension/enabled-monetized.png" | ||
| style="float:left;padding-right:20px" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image and the images below are part Step 2, Step3 and Step 4
| <LinkOut href="https://webmonetization.org/tools/banner"> | ||
| Create a banner | ||
| </LinkOut> | ||
| that appears when your visitors don't have the Web Monetization extension or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting here breaks the line when rendering

Maybe move <linkout> component away from the beginning of the line?
Create a <LinkOut href="https://webmonetization.org/tools/banner"> banner</LinkOut> that appears when your visitors don't have the Web Monetization extension or have the extension turned off. The banner includes a link to download the extension from your visitor's browser store.
PS: prior and additional issues with <Linkout> component at the beginning of the line: here
| @@ -27,31 +28,35 @@ If you have a payment pointer, visit <LinkOut href='https://paymentpointers.org/ | |||
|
|
|||
| ## Step 2 - Web monetize your page | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⬆️ comment
| </Tabs> | ||
| <Tabs> | ||
| <TabItem label="Example payment pointer"> | ||
| ``` $ilp.link/my-wallet ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` $ilp.link/my-wallet ``` | |
| ``` | |
| $ilp.link/my-wallet | |
| ``` |
and also prettier-ignore it somehow
| ``` $ilp.link/my-wallet ``` | ||
| </TabItem> | ||
| <TabItem label="Example wallet address"> | ||
| ``` https://ilp.link/my-wallet ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ``` https://ilp.link/my-wallet ``` | |
| ``` | |
| https://ilp.link/my-wallet | |
| ``` |
Same here