docs: add csp info to pub tools and other updates#627
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
melissahenderson marked as non substantive for IPR from ash-nazg. |
|
Forgot about partials and Prettier. Fixing... |
realized the banner and widget tool buttons on their respective pages were in the wrong place
This comment has been minimized.
This comment has been minimized.
DarianM
left a comment
DarianM
left a comment
There was a problem hiding this comment.
nit: maybe the csp information should be added to the top to be more visible, maybe before the "Create a new tool" paragraph and not scroll all the way to the bottom
|
@DarianM How about a compromise. I'll put a link within a note at the top (in another PR). The reason I don't think it should be first is that it's something you set once. People will probably revisit this page a few times to understand the tool. Having it at the bottom saves them from having to scroll past it every time. |
|
I'd even suggest creating a FAQ/troubleshooting section at the bottom, and hide CSP into a |
4 participants
This update started out as an update to the banner and widget pages, by adding CSP info. (interledger/publisher-tools#515)
While making these updates and clicking through my local version, there were a handful of pages that would break. Long story short, the Steps component wasn't playing nicely with asides. I removed all instances where the Step component was used. Doing this also resolved a few other issues w/ tabs and the LinkOut component.
I also made content updates based on Vale feedback, removed
{/* prettier-ignore */}from places where it's no longer needed, and removed the usage of the Disclosure tag. We stopped using it a while ago, but forgot to change the page.