Conversation
Major updates: - @interledger/docs-design-system: 0.10.3 → 0.11.0 (adds visual emphasis to details component) - globals: 16.5.0 → 17.2.0 (audioWorklet split from browser globals - not used) Minor updates: - astro: 5.16.0 → 5.17.1 (breaking change to experimental Fonts API only - not used) - @astrojs/starlight: 0.36.3 → 0.37.5 - @astrojs/check: 0.9.5 → 0.9.6 - @eslint/js: 9.39.1 → 9.39.2 - eslint: 9.39.1 → 9.39.2 - @typescript-eslint/parser: 8.48.0 → 8.54.0 - typescript-eslint: 8.48.0 → 8.54.0 - prettier: 3.6.2 → 3.8.1 Patch updates: - starlight-links-validator: 0.19.1 → 0.19.2 Testing performed: - Build successful (39 pages built) - All internal links valid - Linting passes - No breaking changes affecting this project
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Infi-Knight marked as non substantive for IPR from ash-nazg. |
Anca2022
left a comment
Anca2022
left a comment
There was a problem hiding this comment.
There's an issue with <details> element overflow
=> I opened an issue regarding it - see DOCSDEV-56 for more details
The rest LMGT :)
|
Do double check the new Linux-specific dependencies don't cause issues on regular Windows dev. |
I don't have access to a Windows env but moving those deps to optional seems to work in the action |
Hey @Infi-Knight! I just tested PR #640 ( |
5 participants
Summary
This PR updates dependencies and fixes documentation formatting, along with CI workflow improvements to support the updated packages.
Changes
Dependency Updates
CI/CD Fixes
@rollup/rollup-linux-x64-gnu@4.53.3as devDependency (fixes Rollup native binary not found in CI)@pagefind/linux-x64@1.4.0as devDependency (fixes Pagefind search indexing in CI)npm ci --include=optionaltonpm installWhy These Changes?
The dependency updates include newer versions of Astro and Starlight which have updated transitive dependencies (Rollup, Pagefind). These packages use platform-specific native binaries that npm's optional dependency handling fails to install correctly in CI environments. By explicitly declaring the Linux x64 versions as devDependencies, they get installed regardless of the host platform.
Verification
new UI for details element:
