Skip to content

pr: [Nightly Fix] - Typo - Polish User Facing Copy #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jewel-claw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pr: [Nightly Fix] - Typo - Polish User Facing Copy #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Hooks/Handlers/DeactivationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function getReasons()
"does_not_work" => array(
"label" => "The plugin didn't work",
"custom_placeholder" => "",
"custom_label" => 'Kindly tell us any suggestion so we can improve',
"custom_label" => 'Please share any suggestions so we can improve.',
'has_custom' => true
),
"temporary" => array(
Expand Down
4 changes: 2 additions & 2 deletions app/Modules/DataProviders/NinjaFooTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ private static function enqueue_assets()
'i18n' => array(
'search_in' => __('Search in', 'ninja-tables'),
'search' => __('Search', 'ninja-tables'),
'empty_text' => __('No Result Found', 'ninja-tables'),
'empty_text' => __('No Results Found', 'ninja-tables'),
Copy link

@qodo-code-review qodo-code-review bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Broken translation lookup 🐞 Bug ✓ Correctness

The msgid was changed to "No Results Found" in NinjaFooTable, but the shipped translation catalogs
still contain "No Result Found", so WordPress will not find a translation and will fall back to
English on localized sites.
Agent Prompt 
### Issue description
The code now translates a new msgid (`"No Results Found"`), but the repo-shipped translation catalogs still contain only the old msgid (`"No Result Found"`). This causes translation lookup failures and English fallback on localized sites.

### Issue Context
This plugin loads translations from `/language` via `load_plugin_textdomain()`, so msgid mismatches directly break localization.

### Fix Focus Areas
- app/Modules/DataProviders/NinjaFooTable.php[69-79]
- app/Modules/DataProviders/NinjaFooTable.php[378-385]
- language/ninja-tables.pot[599-603]
- language/ninja-tables-es.po[530-534]
- vendor/wpfluent/framework/src/WPFluent/Foundation/Application.php[273-286]

### Implementation notes
- Update `language/ninja-tables.pot` to replace/add msgid `"No Results Found"`.
- Update each shipped `language/*.po` to include `msgid "No Results Found"` with an appropriate translation, then recompile the corresponding `language/*.mo`.
- Ensure the old msgid entry is removed or left only if still used elsewhere.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

'clear_all' => __('Clear All', 'ninja-tables'),
'caption_format' => __('Selected', 'ninja-tables'),
'pikaday' => [
Expand Down Expand Up @@ -381,7 +381,7 @@ private static function render($tableArray)
'search' => (isset($settings['search_placeholder']))
? sanitize_text_field($settings['search_placeholder']) : __('Search', 'ninja-tables'),
'no_result_text' => (isset($settings['no_result_text']))
? sanitize_text_field($settings['no_result_text']) : __('No Result Found', 'ninja-tables'),
? sanitize_text_field($settings['no_result_text']) : __('No Results Found', 'ninja-tables'),
),
'shouldNotCache' => isset($settings['shouldNotCache']) ? $settings['shouldNotCache'] : false,
'skip_rows' => Arr::get($settings, 'skip_rows', 0),
Expand Down