Fix: Adding multiple roles in edit user page is not updating after saving #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the multiple roles selector not appearing on the user edit page by updating the page-check condition to include user-edit.php.
- Expanded the conditional to show the roles multiselect on both user creation and edit pages.
- Ensured network admin screens are still excluded.
| ); | ||
|
|
||
| if ( $allow_multiple_roles && ( $profileuser || 'user-new.php' === $pagenow ) && ! is_network_admin() ) { | ||
| if ( $allow_multiple_roles && ( $profileuser || in_array( $pagenow, array( 'user-new.php', 'user-edit.php' ) ) ) && ! is_network_admin() ) { |
There was a problem hiding this comment.
Consider using the strict parameter in in_array (e.g., in_array($pagenow, ['user-new.php', 'user-edit.php'], true)) to ensure type-safe comparisons.
Suggested change
| if ( $allow_multiple_roles && ( $profileuser || in_array( $pagenow, array( 'user-new.php', 'user-edit.php' ) ) ) && ! is_network_admin() ) { | |
| if ( $allow_multiple_roles && ( $profileuser || in_array( $pagenow, array( 'user-new.php', 'user-edit.php' ), true ) ) && ! is_network_admin() ) { |
| ); | ||
|
|
||
| if ( $allow_multiple_roles && ( $profileuser || 'user-new.php' === $pagenow ) && ! is_network_admin() ) { | ||
| if ( $allow_multiple_roles && ( $profileuser || in_array( $pagenow, array( 'user-new.php', 'user-edit.php' ) ) ) && ! is_network_admin() ) { |
There was a problem hiding this comment.
[nitpick] Extract the array of page names into a descriptive variable or constant (e.g., $role_pages = ['user-new.php', 'user-edit.php'];) to improve readability and simplify future updates.
Suggested change
| if ( $allow_multiple_roles && ( $profileuser || in_array( $pagenow, array( 'user-new.php', 'user-edit.php' ) ) ) && ! is_network_admin() ) { | |
| $role_pages = array( 'user-new.php', 'user-edit.php' ); | |
| if ( $allow_multiple_roles && ( $profileuser || in_array( $pagenow, $role_pages ) ) && ! is_network_admin() ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #406
Description
The issue arises from the condition used to display the wpum_user_roles field. When saving a user, this field is not registered in Carbon Fields, leading to the problem.
Testing Instructions
Pre-review Checklist