fix(qa): replace string concatenation with parameterized SQL queries in PROJ-16 cleanup script#13
Closed
Copilot wants to merge 1 commit intochore/proj16-testdata-cleanup-prfrom
Closed
Conversation
15 tasks
Copilot
AI
changed the title
[WIP] WIP address feedback on parameterized placeholders in PROJ-16 testdata script
fix(qa): replace string concatenation with parameterized SQL queries in PROJ-16 cleanup script
Feb 19, 2026
Owner
|
nothing new. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related Features / Issues
Overview of Changes
Eliminated SQL injection risk in
script/qa/cleanup-proj16-testdata.phpby replacing direct string concatenation with parameterized query placeholders:Before:
After:
All
where()anddestroyAll()calls now useIN (?)placeholders with bound array values, consistent with framework patterns inAdvertisement.php:50,PostSet.php:192.QA / Verification
composer run ci:lint: Passcomposer run test: Passcomposer run analyse: Passcomposer run cs-check: PassDeployment Impact
Reviewer Focus
destroyAllandwherecalls use placeholder syntax (IN (?)) with bound parametersChecklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.