Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR completes the PROJ-16 mail namespace decoupling effort by migrating mail and MIME functionality from the Zend\* namespace to MyImouto\* as the canonical implementation, with Zend\* classes retained as compatibility shim wrappers that simply extend their MyImouto counterparts.
Changes:
- Moved mail/MIME class implementations from
lib/Zend/Mail/*andlib/Zend/Mime/*tolib/MyImouto/Mail/*andlib/MyImouto/Mime/* - Converted Zend classes to empty shim wrappers that extend MyImouto classes for backward compatibility
- Added idempotent migration to ensure legacy ip_addr columns exist across drifted schemas
- Added test coverage verifying the shim pattern works correctly
- Updated README with migration notes and rollback guidance
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/MyImouto/Mail/*.php | New canonical mail class implementations (moved from Zend namespace) |
| lib/MyImouto/Mime/*.php | New canonical MIME class implementations (moved from Zend namespace) |
| lib/Zend/Mail/*.php | Converted to compatibility shims extending MyImouto classes |
| lib/Zend/Mime/*.php | Converted to compatibility shims extending MyImouto classes |
| tests/Unit/Mail/NamespaceDecouplingTest.php | New test verifying shim compatibility and end-to-end functionality |
| db/migrate/20260218101500_ensure_legacy_ip_addr_columns_exist.php | Idempotent migration ensuring legacy IP address columns exist |
| README.md | Added migration notes and rollback guidance |
db/migrate/20260218101500_ensure_legacy_ip_addr_columns_exist.php
Outdated
Show resolved
Hide resolved
db/migrate/20260218101500_ensure_legacy_ip_addr_columns_exist.php
Outdated
Show resolved
Hide resolved
db/migrate/20260218101500_ensure_legacy_ip_addr_columns_exist.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related Features / Issues
Overview of Changes
lib/MyImouto/Mail/*andlib/MyImouto/Mime/*lib/Zend/*kept as compatibility shim wrappersdb/migrate/20260218101500_ensure_legacy_ip_addr_columns_exist.phpQA / Verification
composer run ci:lint: passcomposer run test: passcomposer run analyse: skipped (no phpstan config)composer run cs-check: skipped (no cs-fixer config)sudo -u www-data php config/boot.php db:migrateon VPS: passdmails.ip_addrforum_posts.ip_addrforum_posts.updater_ip_addrcomments.updater_ip_addr/-> 200/user/login-> 200ip_addr-> OKDeployment Impact
/home/vps/myimouto-backup.sql)Reviewer Focus
Checklist