Remove image standardization and implement consistent filename sanitization#12
Merged
Remove image standardization and implement consistent filename sanitization#12
Conversation
…zation - Removed standardized naming (screenshot_original, thumbnail_original) from Internet Archive indexer - Images now retain their original filenames from all sources - Implemented consistent filename sanitization across all indexers: - Internet Archive: Now sanitizes image filenames in addition to .dat files - Discord indexers: Now sanitizes all attachment filenames (.dat, images, .zip) - Hognose indexer: Now sanitizes all asset filenames from GitHub releases - Security improvements prevent path traversal attacks and filesystem issues - All filenames are sanitized using FileUtils.sanitizeFilename() which: - Removes dangerous characters (<>:"/\|?*) - Replaces spaces with underscores - Limits filename length to 100 characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the standardized image naming convention from the Internet Archive indexer and implements consistent filename sanitization across all indexers for improved security.
Changes Made
screenshot_original.{ext}andthumbnail_original.{ext}FileUtils.sanitizeFilename()to all downloaded files across all indexers:Testing
Impact
This change improves security by preventing path traversal attacks and filesystem issues while maintaining better traceability to source files through preserved original filenames.