FEAT: #529 Changed anomalies to always give a reward #555
+19
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immortius
requested changes
Feb 1, 2026
Contributor
immortius
left a comment
immortius
left a comment
There was a problem hiding this comment.
The anomaly reward data fix is good, although there's still only a chance of getting an item. I was wondering if there is a reason that strength has been replaced with absorption?
|
|
||
| public record AnomalyReward(Optional<MobEffectInstance> effect/* potential alternative: it could cast an ability */, | ||
| Optional<ResourceKey<LootTable>> lootKey) { | ||
| public record AnomalyReward(MobEffectInstance effect/* potential alternative: it could cast an ability */, |
Contributor
There was a problem hiding this comment.
I don't think these code changes are necessary - and it would be good to keep the two possible reward types as optional is it isn't necessary for an Anomaly to reward both. Changing the configuration to have a guaranteed reward is probably enough (although I would note that the loot table is still only a chance of giving an item).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make anomalies to always give as a reward a loot table and an effect.