Added Shop Interface #109
Merged
Added Shop Interface #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks. One thing to keep in mind though is that the images for the documentation which I'm assuming you actually have them are in a different repo. The repos for 2.0 are a little bit more complicated but long story short, is so that the library is quite small and very quick to download, this allows me to version manage it for people easily by deleting it and downloading the new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my tests it seems to be completely working. Heavily inspired by @J-Flight original Store interface from Wasplib 1.4. With modifications to follow the standards I saw in Bank and Anvil interfaces. Still have a few things todo such as caching and getting the nearest merchants and shops. But right now it is ready to be used for shop scripts.