Skip to content

Magic.IsSelected was missing the b var to read the out param from Mag… #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XxXAdvisaryXxX wants to merge 1 commit into from
Closed

Magic.IsSelected was missing the b var to read the out param from Mag… #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions osrs/interfaces/gametabs/magic.simba
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,18 +446,18 @@ WriteLn Magic.IsSpellSelected(ERSSpell.ICE_BARRAGE);
*)
function TRSMagic.IsSelected(spell: ERSSpell): Boolean;
var
bounds: TBox;
b,bounds: TBox;
begin
if spell in RS_INSTANT_THROW_SPELLS then Exit;
Result := Self.FindSpell(spell, bounds) and Target.HasColor($FFFFFF, 0, 10, bounds.Expand(2));
Result := Self.FindSpell(spell, b) and Target.HasColor($FFFFFF, 0, 10, bounds.Expand(2));
end;

function TRSMagic.IsSelected(spell: ERSSpell; selected: TPointArray): Boolean; overload;
var
bounds: TBox;
b,bounds: TBox;
begin
if spell in RS_INSTANT_THROW_SPELLS then Exit;
if not Self.FindSpell(spell, bounds) then Exit;
if not Self.FindSpell(spell, b) then Exit;
Result := bounds.Contains(selected.Mean());
end;

Expand Down