Skip to content

Escapes XML in GPX route data #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josh-vin wants to merge 2 commits into from
Closed

Escapes XML in GPX route data #1185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ef1d9b
Escapes XML in GPX route data
josh-vin Jan 6, 2026
26670e6
Prettier
josh-vin Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/features/route/RoutePopup.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,24 @@ export function RoutePopup({ end, inline = false, ...props }) {
}

function DownloadRouteGPX({ route }) {
const escapeXml = (value = '') =>
String(value).replace(
/[<>&'"]/g,
(c) =>
({
'<': '&lt;',
'>': '&gt;',
'&': '&amp;',
"'": '&apos;',
'"': '&quot;',
})[c],
)

const sanitizeFilename = (name = '') =>
String(name)
.replace(/[\/:*?"<>|]/g, '')
.slice(0, 200) || 'route'

const GPXContent = React.useMemo(() => {
if (!route.waypoints.length) {
return null
Expand All @@ -396,8 +414,8 @@ function DownloadRouteGPX({ route }) {
return `<?xml version="1.0" encoding="UTF-8"?>
<gpx version="1.1" creator="ReactMap" xmlns="http://www.topografix.com/GPX/1/1">
<rte>
<name>${route.name}</name>
<desc>${route.description}</desc>
<name>${escapeXml(route.name)}</name>
<desc>${escapeXml(route.description)}</desc>
${route.waypoints
.map(
(waypoint) =>
Expand All @@ -417,7 +435,7 @@ function DownloadRouteGPX({ route }) {
href={`data:application/gpx;charset=utf-8,${encodeURIComponent(
GPXContent,
)}`}
download={`${route.name}.gpx`}
download={`${sanitizeFilename(route.name)}.gpx`}
size="small"
style={{ color: 'inherit' }}
>
Expand Down
Loading