Skip to content
This repository was archived by the owner on Oct 27, 2025. It is now read-only.

notification filter / storage change#122

Merged
arr0ganc3s merged 3 commits intoWayneKeenan:mainfrom
fanno:feature/storagechange
Aug 18, 2025
Merged

notification filter / storage change#122
arr0ganc3s merged 3 commits intoWayneKeenan:mainfrom
fanno:feature/storagechange

Conversation

@fanno
Copy link

@fanno fanno commented Aug 8, 2025

  • Moved notification data to the plugin side.
  • Moved filter of notifications to the plugin side so if all notifications happen to be muted no popup will happen at all.

  • The target of this PR is the main branch.
  • No commits are missing from forked base branch (e.g. modified main branch instead of dev)
  • You have squashed commits that might be considered: 'noisy' or partial, e.g. not candidates for cherry picking
  • All test pass, run npm test
  • The code is formatted, run npm run format
  • You have updated or added test cases, as/if required
  • You have installed and tried out the plugin in a supported browser

@arr0ganc3s
Copy link
Collaborator

please resolve the conflicts

@fanno
Copy link
Author

fanno commented Aug 18, 2025

I was not able to Squask the merge with the fixed issue commit. so it had to make it like this

it's also retested in chrome and firefox and npm run test

@arr0ganc3s arr0ganc3s merged commit 5151b74 into WayneKeenan:main Aug 18, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants