Skip to content
This repository was archived by the owner on Oct 27, 2025. It is now read-only.

Refactor to use new article type classes#124

Merged
arr0ganc3s merged 8 commits intoWayneKeenan:mainfrom
schang1146:sc/refactor-article-types
Aug 18, 2025
Merged

Refactor to use new article type classes#124
arr0ganc3s merged 8 commits intoWayneKeenan:mainfrom
schang1146:sc/refactor-article-types

Conversation

@schang1146
Copy link
Contributor

Thank you for your contribution to the ClintonCAT repo.
Before submitting this PR, please make sure:


  • The target of this PR is the main branch.
  • No commits are missing from forked base branch (e.g. modified main branch instead of dev)
  • You have squashed commits that might be considered: 'noisy' or partial, e.g. not candidates for cherry picking
  • All test pass, run npm test
  • The code is formatted, run npm run format
  • You have updated or added test cases, as/if required
  • You have installed and tried out the plugin in a supported browser

Chromium (Chrome, Brave, etc.):
I think something broke on the main branch. Tested functionality on both heads and the extension wouldn't do any notification and had errors in the console. Not fixing in this PR but might look at that next.

Firefox:
Screenshot from 2025-08-18 06-17-36

Copy link
Collaborator

@arr0ganc3s arr0ganc3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Running on chromium seems good on my end, no errors. Please squash commits next time.

@arr0ganc3s arr0ganc3s merged commit 5b7759a into WayneKeenan:main Aug 18, 2025
1 check passed
@schang1146 schang1146 deleted the sc/refactor-article-types branch August 31, 2025 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants