Open
Conversation
This caused an error on MOP. But also makes the code resilent against furhter changes
It's only needed for the Spell Useable trigger and the Spell Useable condition.
Change how custom code (and internal code) indicates that a state should be shown. Instead of relying on the magic property "show", the existenance of a state is enough. Adding a state to the allstates table shows it, removing a state from allstates hides it. Thus setting state.show to true or false is no longer necessary, although for backwards compability setting show to false still hides clones. Setting show to nil was never intended but had the same effect as setting it to false. For existing aura a compability flag is set, although if a custom TSU updater sets show to nil, the aura gets a warning. This also fixes WeakAuras#5942, because the states are now removed from allstates before the progress update is run. Thus the stale information is no longer used. Fixes: WeakAuras#5942
When multiple triggers provide state then their states (or more accurately their cloneIds) are matched. Tweak the rules a bit to benefit BT2. If an exact match to a cloneId is not found in the other triggers, then the "prefix" of the cloneId is tried next. The prefix is the string before the first "." In "Combine matches per unit" the cloneId remains the unit. If the "Combine matches per unit" is not set, BT2 sets the cloneId's prefix to the unit. Thus if the BT2 trigger is the dynamic information providing trigger, and other triggers use unit based cloneIds those get matched.
Though keep it in the state, since people apparently use it.
All except: * Wago Update, needs SortDisplayButtons(nil, true) * Clear Saved Data. I didn't check what we should do on undo This increases Undos coverage to around 6/301
Makes the TimeMachine responsible for approximately 12/301 places. Unforunately we need separate setAll methods, so each tab has to switch to the TimeMachine at once.
Increases the count of converted places to roughly 16/303
…kAuras#4863 Increases the converted count to roughly 60/303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.