Skip to content

Conversation

@ieow
Copy link

@ieow ieow commented May 10, 2025

Description

Integration the following social login via the OAuth Service and SeedlessController,

Google
Apple

Proposed Authentication Flow using seedless onboarding
Screenshot 2025-04-29 at 8 25 46 PM

This PR mainly integrate the Seedless Controller and the OAuthServices into Metamask.
It does not include the Login UI Flow.
The Login UI Flow will be added on top of the new SRP UI Flow

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ieow ieow marked this pull request as ready for review May 10, 2025 03:34
@github-actions
Copy link

github-actions bot commented May 10, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ieow ieow force-pushed the feat/oauth-integration branch from 2b1456c to a65cd8d Compare May 14, 2025 09:43
@ieow ieow changed the title Feat/oauth integration Feat : 1.8 Oauth and controller integration May 14, 2025
@ieow ieow changed the base branch from feat/new-srp-flow to feat/new-srp-setting-password May 14, 2025 10:13
@ieow
Copy link
Author

ieow commented May 14, 2025

I have read the CLA Document and I hereby sign the CLA

@ieow
Copy link
Author

ieow commented May 20, 2025

Added new directories to .github/CODEOWNERS

@ieow
Copy link
Author

ieow commented May 20, 2025

quote
I don't have visibility to the seedless onboarding controller. Does the controller use actions or events of other controllers?
Previously, there is no actions and events.
Recent features require some controllers' events. Added the events

"react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^1.10.3",
"react-native-get-random-values": "^1.8.0",
"react-native-google-acm": "git+https://github.com/Web3Auth/react-native-google-acm.git#3ad58f4c11273ba102ede93d2a3148e45c84d248",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we bypass the paid version by forking our own and adding our own implementation?
Yes, we use react-native wrapper to call google account credentials manager for android seamless login

@ieow ieow changed the title Feat : 1.8 Oauth and controller integration Feat : 2.1 Oauth and controller integration May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants