feat: 1.3 new srp ui welcome screen #34
Open
+995
−821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
tommasini
reviewed
May 21, 2025
| StyleSheet.create({ | ||
| scroll: { | ||
| flex: 1, | ||
| // marginTop: 100, |
|
Can we have screenshots at the PR description? It would be awesome! |
Author
|
added screenshot ! |
Co-authored-by: smgv <[email protected]>
fix: remove unused variables
ieow
force-pushed
the
feat/srp-onboarding-carousel-tnc
branch
from
2afe811 to
2ace86b
Compare
ieow
force-pushed
the
feat/srp-onboarding-carousel-tnc
branch
from
e111fcf to
ceab2f4
Compare
tommasini
reviewed
May 23, 2025
| const innerStyles = StyleSheet.create({ | ||
| headerStyle: { | ||
| backgroundColor: themeColors.background.default, | ||
| backgroundColor: color || themeColors.background.default, |
There was a problem hiding this comment.
Would rename color to backgroundColor be more accurate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.3
Update New SRP onboarding flow as per figma design
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=434-55200&t=wmEoQSF9g9lFtkwp-0
This PR is part 3 of 7 for the new SRP ui update
This PR cover
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-05-21.at.8.49.18.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist