Skip to content

Conversation

@ieow
Copy link
Contributor

@ieow ieow commented Jan 13, 2025

Motivation and Context

Jira Link:

Currently we depend on ability of factor to retrieve shareStore to reject or accept the factor.
Adding this logic checking availability of factorPub against the metadata

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himanshuchawla009 himanshuchawla009 merged commit f1c2c50 into master Jan 14, 2025
3 checks passed
@himanshuchawla009 himanshuchawla009 deleted the feat/inputFactorKeyCheck branch January 14, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants