adds socket transports option in sdk constructor #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
himanshuchawla009
commented
Sep 10, 2025
himanshuchawla009
commented
- adds socket transports option in sdk constructor
matthiasgeihs
approved these changes
Sep 10, 2025
Comment on lines
+21
to
+22
| // import { tssLib } from "@toruslabs/tss-dkls-lib"; | ||
| import{ tssLib } from "@toruslabs/tss-frost-lib"; |
Contributor
There was a problem hiding this comment.
You probably don't want to change that permanently, as some of the functions of the demo don't work with frost.
Member
Author
There was a problem hiding this comment.
ok will update.
|
|
||
| // Setup sockets. | ||
| const sockets = await setupSockets(tssWSEndpoints, randomSessionNonce); | ||
| const sockets = await setupSockets(tssWSEndpoints, randomSessionNonce, "/tss/socket.io", this.socketTransports); |
Contributor
There was a problem hiding this comment.
Is it intentional that you set the path here? Otherwise you can also insert undefined and it will fallback to the default as before.
| { | ||
| "name": "@web3auth/mpc-core-kit", | ||
| "version": "3.4.3", | ||
| "version": "3.5.0-0", |
Member
Author
There was a problem hiding this comment.
i did a pre-release from this branch, will do the final release once after merging to master
| data, | ||
| serverCoefficientsHex | ||
| serverCoefficientsHex, | ||
| this.socketTransports |
Contributor
There was a problem hiding this comment.
Wasn't there another parameter here?
Member
Author
There was a problem hiding this comment.
that's on another version of tss client which is not in production yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.