Skip to content

sort login methods from auth connection in project config#2133

Merged
chaitanyapotti merged 2 commits intomasterfrom
feat/v10-login-modal
Apr 11, 2025
Merged

sort login methods from auth connection in project config#2133
chaitanyapotti merged 2 commits intomasterfrom
feat/v10-login-modal

Conversation

@tanguyenvn
Copy link
Contributor

@tanguyenvn tanguyenvn commented Apr 11, 2025

Motivation and Context

Jira Link: N/A

Description

  • Sort login methods using following order. Config in code will take precedence over dashboard config.
    const AUTH_CONNECTION_ORDER = [
    AUTH_CONNECTION.GOOGLE,
    AUTH_CONNECTION.TWITTER,
    AUTH_CONNECTION.FACEBOOK,
    AUTH_CONNECTION.DISCORD,
    AUTH_CONNECTION.FARCASTER,
    AUTH_CONNECTION.APPLE,
    AUTH_CONNECTION.GITHUB,
    AUTH_CONNECTION.REDDIT,
    AUTH_CONNECTION.LINE,
    AUTH_CONNECTION.KAKAO,
    AUTH_CONNECTION.LINKEDIN,
    AUTH_CONNECTION.TWITCH,
    AUTH_CONNECTION.WECHAT,
    ];

How has this been tested?

Screenshots (if appropriate):

image
image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 9:55am

@tanguyenvn tanguyenvn self-assigned this Apr 11, 2025
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chaitanyapotti chaitanyapotti merged commit 7270c72 into master Apr 11, 2025
4 of 5 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/v10-login-modal branch April 11, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants