fix: skip adding MM connector for solana chain #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tanguyenvn
commented
Nov 28, 2025
| if ((error as { code?: number })?.code === 4902) { | ||
| const chainConfig = this.coreOptions.chains.find( | ||
| (x) => | ||
| x.chainId === params.chainId && ([CHAIN_NAMESPACES.EIP155, CHAIN_NAMESPACES.SOLANA] as ChainNamespaceType[]).includes(x.chainNamespace) |
Contributor
Author
There was a problem hiding this comment.
MM connector doesn't support Solana atm, so excluding it
tanguyenvn
force-pushed
the
fix/W3APD-5197-solana-mm-connector
branch
from
bd2fbe4 to
c4cbbe5
Compare
tanguyenvn
commented
Nov 28, 2025
| // it's safe to add it here as if there is a MetaMask injected provider, this won't override it | ||
| // only set headless to true if modal SDK is used, otherwise just use the modal from native Metamask SDK | ||
| if (isBrowser() && (chainNamespaces.has(CHAIN_NAMESPACES.SOLANA) || chainNamespaces.has(CHAIN_NAMESPACES.EIP155))) { | ||
| connectorFns.push(metaMaskConnector(modalMode ? { headless: true } : undefined)); |
Contributor
Author
There was a problem hiding this comment.
- we already prioritize MM connector at the line 697-699 when EVM chain is available
- if only Solana chain namespace available, we should not add MM connector.
chaitanyapotti
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link: https://consensyssoftware.atlassian.net/browse/W3APD-5197
Currently, when only Solana chain is used, MM connector (EVM-only) is always included
This is incorrect.
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: