Feature/platform fee calculator#172
Merged
Akshola00 merged 5 commits intoWeb3Novalabs:mainfrom Feb 25, 2026
Merged
Conversation
…port - Add internal helper function to calculate platform fees - Support basis points (e.g., 250 bps for 2.5%) - Include overflow protection with checked arithmetic - Add comprehensive test suite covering: - Small and large amounts - Edge cases and overflow scenarios - Realistic crowdfunding scenarios - Precision and rounding behavior - Stellar XLM amount calculations Closes #[issue-number]
- Explain basis points concept - Provide usage examples and integration guide - Document safety features and error handling - Include test coverage details - Add best practices and future enhancements
- Align struct field comments properly - Remove extra blank line in overflow check - Ensure consistent spacing per rustfmt rules
- Change function visibility from private to pub(crate) for testing - Add extern crate std for vec! macro in tests - Fixes E0624 compilation errors in test suite
- Replace vec! with std::vec! for explicit namespace - Ensures proper macro resolution in Soroban test environment
Contributor
|
thanks fr your contribution @Benalex8797 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #91