feat: implement get_pool_remaining_time function#173
Merged
Akshola00 merged 3 commits intoWeb3Novalabs:mainfrom Feb 25, 2026
Merged
feat: implement get_pool_remaining_time function#173Akshola00 merged 3 commits intoWeb3Novalabs:mainfrom
Akshola00 merged 3 commits intoWeb3Novalabs:mainfrom
Conversation
Contributor
|
@mayasimi thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #90
What was done:
Added get_pool_remaining_time function to the CrowdfundingTrait interface
Implemented the function in crowdfunding.rs — returns seconds remaining until the pool deadline, or 0 if the deadline has already passed
Used saturating_sub to safely handle expired pools without underflow
Added 3 tests in pool_remaining_time_test.rs covering: time remaining, expired pool returning zero, and pool not found error
How it works:
The deadline is calculated as created_at + duration, which is consistent with how the rest of the contract (e.g. refund) handles pool deadlines. The ledger timestamp is used for the current time via env.ledger().timestamp().