Clarify the implicit bind behavior observed on Windows. #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of
tcp-socket::listenmentions:I've recently added tests for this in wasmtime.
The tests ran fine on Linux and MacOS but failed on Windows. Apparently, Windows does not perform an implicit bind as part of
listen.I've updated wasmtime to perform the bind explicitly if the guest hasn't already done so. This makes it behave the same on all platforms.
This PR adds a note on
listenclarifying the expected WASI behavior and observed OS behavior.