Fix some Closure warnings in Emscripten builds #5075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructs Closure about the types in play so the warnings go away.
Didn't encounter the externs warning regarding the. Generally it looks that we could refactor the code slightly to useWebAssemblyobject (need to see what CI states)classes, then we'd not need to annotate in comments so much (except the dynamically generated expression methods).Related #5062
Update: Seen the
WebAssemblyobject externs warning now, which might require a fix to the externs provided by Emscripten.