Remove incorrect assertion in IRBuilder #8177
Merged
+61
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRBuilder has to handle the case where a branching instruction like br_on_null sends a value to its target label, even though we cannot directly represent such a value being sent in our IR. To do so, it adds an extra trampoline label that fetches the sent value out of scratch locals before branching to the original target. We previously had an assertion that the scratch local used to hold such extra values had the same type as the expression with the destination label. This is usually true, but it is possible that the destination label is on an If with an unreachable condition, in which case the destination has type unreachable and the scratch local has the original concrete label type. Remove the incorrect assertion. Fixes #8096.
kripken
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRBuilder has to handle the case where a branching instruction like
br_on_null sends a value to its target label, even though we cannot
directly represent such a value being sent in our IR. To do so, it adds
an extra trampoline label that fetches the sent value out of scratch
locals before branching to the original target.
We previously had an assertion that the scratch local used to hold such
extra values had the same type as the expression with the destination
label. This is usually true, but it is possible that the destination
label is on an If with an unreachable condition, in which case the
destination has type unreachable and the scratch local has the original
concrete label type. Remove the incorrect assertion.
Fixes #8096.