feat(jsapi): Implement Table Bindings #8186
Open
+182
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr implements the table bindings I wasn't quite sure what was meant by in parrellel to the memory stuff, so I put it after the function stuff like it is in the c api, happy to change this however. Let me know if there are any changes that need to be made. Closes: WebAssembly#8122 Notes: * I removed the getInfo table tests in kitchen-sink and moved them here as it's more specific * I added jsdoc which isn't something i've seen through the js api but it does however seem helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements the table bindings I wasn't quite sure what was meant by in parrellel to the memory stuff, so I put it after the function stuff like it is in the c api, happy to change this however.
Let me know if there are any changes that need to be made.
Closes: #8122
Notes:
I'm pretty sure that for adding the
Elem Segment Operationsit would be bassically the exact same patterns so I can probably do that as well once this is okay'd.