Skip to content

enforce enum and variant types being non-empty #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

enforce enum and variant types being non-empty #346

merged 1 commit into from
Apr 24, 2024

Conversation

rvolosatovs
Copy link
Contributor

Enforce enum and variant type definitions to be non-empty in Binary.md

refs #336 (comment)

This is similar to #218

@rvolosatovs rvolosatovs mentioned this pull request Apr 22, 2024
Merged
lukewagner
lukewagner approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch, thanks!

@lukewagner lukewagner merged commit 34dfef3 into WebAssembly:main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewagner lukewagner lukewagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvolosatovs @lukewagner