Skip to content

[js-api] Add test case for externref global #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[js-api] Add test case for externref global #1983

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c857e83
[js-api] Add test case for externref global
Liedtke Sep 23, 2025
d82c98b
Only test the constructor
Liedtke Oct 20, 2025
4cb2ba5
Add test case for value assignment and valueOf()
Liedtke Oct 20, 2025
76ac446
remove Object.is again
Liedtke Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion test/js-api/global/constructor.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ function assert_Global(actual, expected) {

assert_equals(actual.value, expected, "value");
assert_equals(actual.valueOf(), expected, "valueOf");
assert_true(Object.is(actual.value, expected), "value Object.is");
assert_true(Object.is(actual.valueOf(), expected), "valueOf Object.is");
}

test(() => {
Expand Down Expand Up @@ -167,5 +169,29 @@ test(() => {

test(() => {
const argument = { "value": "v128" };
assert_throws_js(TypeError, () =>new WebAssembly.Global(argument));
assert_throws_js(TypeError, () => new WebAssembly.Global(argument));
}, "Construct v128 global");

test(() => {
for (let value of [
undefined,
null,
true,
1,
-0,
1.5,
-2n,
Symbol("test"),
"string",
{"an": "object"},
() => null
]) {
let global = new WebAssembly.Global({value: "externref"}, value);
assert_Global(global, value);
}
}, "externref global");

test(() => {
let global = new WebAssembly.Global({value: "externref"});
assert_Global(global, undefined);
}, "externref global with default value");
21 changes: 21 additions & 0 deletions test/js-api/global/value-get-set.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,24 @@ test(() => {
assert_equals(setter.call(global, 1, {}), undefined);
assert_equals(global.value, 1);
}, "Stray argument");

test(() => {
let global = new WebAssembly.Global({value: "externref", mutable: true});
for (let value of [
undefined,
null,
true,
1,
-0,
1.5,
-2n,
Symbol("test"),
"string",
{"an": "object"},
() => null
]) {
global.value = value;
assert_equals(global.value, value);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #1984 (comment), this tests -0 as one of its inputs. assert_equals already treats 0 and -0 as different values:

assert_equals: expected -0 but got 0

Let me know if this is fine given that the current spec text isn't very precise.

assert_equals(global.valueOf(), value);
}
}, "externref global");