[js-api] Fix result types in string builtins #2054
Conversation
The string builtins that return strings should return non-nullable `(ref extern)`` rather than nullable `externref`. This change reflects current implementation reality in both Chrome and FireFox.
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Seems fine. I'd like @sideshowbarker's review of the echidna failures before merging, though
jakobkummerow
left a comment
jakobkummerow
left a comment
There was a problem hiding this comment.
LGTM.
FWIW, (ref extern) is what the proposal's Overview has always said. Dunno why the final spec ended up diverging from that; I'm guessing that wasn't intentional.
|
cc @rmahdav |
Our charter has expired, so we no longer have perms to (auto)publish to TR space. I’ve sent a request for an extension of the charter. If/when that gets OKed, the echidna failures should go away. |
No more echidna failures. We got our charter extension — so it’s back again to working now. All green 🍀 |
|
Thanks! |
The string builtins that return strings should return non-nullable
(ref extern)rather than nullableexternref. This change reflects current implementation reality in both Chrome and FireFox.