[js-api] Test validation of string builtin types #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation should fail if string builtin imports do not have the expected types. Add a test for this validation.
Member
Author
|
I validated locally (by applying this diff to WPT) that FireFox passes this new test. Chrome does not, however, because V8 currently checks the builtin params and results individually instead of checking the entire import type. It seems worth fixing this (and testing it) to avoid compatibility hazards. |
Ms2ger
approved these changes
Jan 19, 2026
Member
Author
|
cc @rmahdav |
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Jan 21, 2026
Among others, this rolls github.com/WebAssembly/spec/pull/2055, which we just fixed in V8. Change-Id: I6e0329901cd2bbca560717c6034750d7d4a75eb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7503055 Auto-Submit: Jakob Kummerow <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/main@{#104813}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation should fail if string builtin imports do not have the expected types. Add a test for this validation.