Fix Emscripten warnings by removing deprecated writeAsciiToMemory#2724
Merged
sbc100 merged 8 commits intoWebAssembly:mainfrom Mar 17, 2026
Merged
Fix Emscripten warnings by removing deprecated writeAsciiToMemory#2724sbc100 merged 8 commits intoWebAssembly:mainfrom
sbc100 merged 8 commits intoWebAssembly:mainfrom
Conversation
The Emscripten function writeAsciiToMemory has been deprecated and logs warnings during the build process. - Replaced usages of writeAsciiToMemory in wabt.post.js with TextEncoder - Fixed a 1-byte buffer overflow in allocateCString - Removed writeAsciiToMemory from CMake EXPORTED_RUNTIME_METHODS
sbc100
reviewed
Mar 17, 2026
sbc100
reviewed
Mar 17, 2026
Contributor
Author
|
PTAL |
kevmoo
commented
Mar 17, 2026
| function parseWat(filename, buffer, options) { | ||
| let errors = new Errors('text'); | ||
| const lexer = new Lexer(filename, buffer, errors); | ||
| errors.lexer = lexer; |
Contributor
Author
There was a problem hiding this comment.
This was just silly!
kevmoo
commented
Mar 17, 2026
sbc100
reviewed
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Emscripten function writeAsciiToMemory has been deprecated and logs warnings
during the build process.