Add wasi/version.h
#703
Merged
Add wasi/version.h
#703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a step towards WebAssembly#688 this adds a new header which ensures that the `__wasipN__` variables are defined. These will eventually be provided via llvm/llvm-project#165345 but in the meantime this uses a header to define them. This then additionally refactors the internals to have `wasi/wasip{1,2}.h` as well as `wasi/api.h` which includes the correct header. The previous `__wasilibc_use_wasip2` macro is removed entirely in favor of `__wasip2__` defined in this header.
Collaborator
Author
|
Note that this is split out of #700 to see more about the end goal |
This isn't necessary now and pulls in too many other headers.
pchickey
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step towards #688 this adds a new header which ensures that the
__wasipN__variables are defined. These will eventually be provided via llvm/llvm-project#165345 but in the meantime this uses a header to define them.This then additionally refactors the internals to have
wasi/wasip{1,2}.has well aswasi/api.hwhich includes the correct header. The previous__wasilibc_use_wasip2macro is removed entirely in favor of__wasip2__defined in this header.