Add GitHub actions for linting/building of registry #91
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| lint-and-build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "20" | ||
| cache: "npm" | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run lint-staged | ||
| run: npx lint-staged | ||
|
Owner
There was a problem hiding this comment. This command should be broken into two different jobs |
||
|
|
||
| - name: Run Astro check | ||
| run: npx astro check | ||
| env: | ||
| GITHUB_REPO_URL: https://github.com/WebDevSimplified/wds-shadcn-registry | ||
| DEPLOY_PRIME_URL: https://localhost:4321 | ||
| URL: https://wds-shadcn-registry.netlify.app | ||
|
|
||
| - name: Build registry | ||
|
Owner
There was a problem hiding this comment. This doesn't actually ensure the registry that is committed is the same as the one built by this command. We probably need to add a diff step to ensure the code in the registry folder doesn't change after running this since if it does change it means the registry is not being built before pushing. |
||
| run: npm run registry:build | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we break each linting and formatting task into its own job? This will ensure they all run in parallel and each will throw their own errors which means if the linting and formatting is broken we will get two errors instead of only one of them running and throwing an error.