-
Notifications
You must be signed in to change notification settings - Fork 16
New Workload: React Server Side Rendering Startup #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Also, seems to be dominated by utf-16 parsing. Ditto on repeating #124 here. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this LGTM now.
BUNDLE_BLOB: "./web-ssr/dist/bundle.min.js", | ||
}, | ||
tags: ["Default", "web", "ssr"], | ||
iterations: 30, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to play with the worstCase counts since there's not a lot of iterations here. 2-3 seems standard. We can do that in a follow up though (please file an issue though).
Filed #184 to do this as global analysis across all workloads. |
I've create a react app that renders a little wine-collection with different react components.
Currently the setup uses webpack to build a web-bundle that we can run in the browser.
For cache-busting new sources are generated for each iteration and the custom comment is replaced with iteration-unique string.
This is a first iteration of this approach / workload happy to get some feedback.