The Scatter Plot Should Increase with the Score #254
Conversation
Right now when the score goes up the scatter plots go down. This is a bit confusing since a higher score is better. I think it would be clearer if the plots reflected this.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
With the change in this PR the charts look like |
|
I guess the underlying potential confusion here is that the scatter plot shows iteration times not scores. I do like however the absolute times instead of scores for quick debugging or judging tier-up behavior. Maybe we should simply add a label below or a y-axis label mentioning "times in ms" or so (right now only shown on hover)? I am not a big fan of inverting the y-axis, that's quite unconventional for times, no? |
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
Thanks, now it makes more sense: The scatter plot also shows scores, where higher is better (as you wanted). One nit to show raw time on hover.
JetStreamDriver.js
Outdated
| const cx = padding + i * xRatio; | ||
| const cy = height - padding - (result - minResult) * yRatio; | ||
| const title = `Iteration ${i + 1}: ${uiFriendlyDuration(result)}`; | ||
| const title = `Iteration ${i + 1}: ${uiFriendlyScore(result)}`; |
There was a problem hiding this comment.
Can we print Iteration 1: x ms, score y maybe, so have both available (and it's only on hover, so not cluttering for those that only care about the quick visual impression).
I just changed it to use scores instead of times. I guess I was inverting the times rather than fixing the scores, which is silly although both are normalized anyway. |
3 participants
Right now when the score goes up the scatter plots go down. This is a bit confusing since a higher score is better. I think it would be clearer if the plots reflected this.