-
Notifications
You must be signed in to change notification settings - Fork 19
Add initial README with some setup and runner instructions #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eqrion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Drive-by: fix some wrong links in the HTML (e.g., no CSS for in-depth.html and wrong link to in-depth.html from index.html). |
camillobruni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo scoring section nit (not feeling strongly about that one).
|
Since this is mostly additive and meant as a first version to iterate on, I'll merge this for now. |
|
|
||
| ### Preloading and Compression | ||
|
|
||
| The JetStream driver (both in the browser and shell runners) _preloads_ some large assets and source files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unclear what preloading means in this context. Might be worth splitting this into two parts e.g.
#### Network prefetching
In order to avoid the CPU frequency spinning down between tests we prefetch all assets before any of the tests start in the browser (In the CLI we assume all assets are on disk). Assets are saved in a blob URL so they can be cached on disk. This lowers the peak memory footprint of the benchmark to a sustainable level.
#### Large Asset preloading
The JetStream driver (both in the browser and shell runners) _preloads_ some large assets and source files. This avoids extensive disk I/O from the memory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, I'll use that tomorrow in a follow-up (or feel free to send a quick PR, whatever works).
Let's iterate later but start with a very simple first version already. Fixes #107.
Rendered doc, updated in-depth doc.