Move quicksort-wasm to JS-style scoring #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Ah, I just see that @eqrion already gave a 👍 on the original post, so I believe it's good to go. |
The usual changes: use `WasmEMCCBenchmark` class for running, rebuild and add build script, use iteration count that makes the Wall time not too high (<2s) In this case, we spend a bit more time in the top-tier than before. However, that line item earlier ran a single <50ms iteration, and compiled for ~2ms, so I would argue it was very prone to noise, and it's good that we run it for longer.
danleh
force-pushed
the
quicksort-wasm-scoring
branch
from
abecd42 to
9e13964
Compare
Contributor
Author
|
Rebased, @kmiller68 should be good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual changes: use
WasmEMCCBenchmarkclass in the runner, rebuild and add build script, use iteration count that makes the Wall time not too high (<2s).In this case, we spend a bit more time in the top-tier than before. However, that line item earlier ran a single <50ms iteration, and had a startup time of ~2-3ms, so I would argue it was very prone to noise, and it's good that we run it for longer.