Skip to content

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Jan 29, 2025

  • Use latest action versions
  • Bump node version to current stable v22
  • Use caches for node modules to slightly speed up setup
  • Mild formatting was applied

@netlify
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for webkit-speedometer ready!

Name Link
🔨 Latest commit a8686c5
🔍 Latest deploy log https://app.netlify.com/sites/webkit-speedometer/deploys/67a2326a79fad3000894db8f
😎 Deploy Preview https://deploy-preview-478--webkit-speedometer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@camillobruni
Copy link
Contributor Author

Simplified the test.yml file based on the feedback.
Looks like the netlify deployment is now unhappy with the upped node version requirement. @julienw is this easy to fix or should I just lower the requirements again?

@julienw
Copy link
Contributor

julienw commented Feb 4, 2025

Simplified the test.yml file based on the feedback. Looks like the netlify deployment is now unhappy with the upped node version requirement. @julienw is this easy to fix or should I just lower the requirements again?

image
just changed it :)

Another way would be to use a .node-version or .nvmrc file in the repository (this would also override any setting in the configuration UI BTW). I think node-version-file can also use that one BTW.
It's a bit too bad that netlify can't use the version specified in package.json :(

Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@camillobruni camillobruni merged commit 763c517 into WebKit:main Feb 27, 2025
8 checks passed
@camillobruni camillobruni deleted the 2025-01-29_gh_actions branch February 27, 2025 16:59
@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trivial change A change that doesn't affect benchmark results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants