Skip to content

Conversation

@flashdesignory
Copy link
Contributor

original pr: #428

@netlify
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for webkit-speedometer ready!

Name Link
🔨 Latest commit 9f60e63
🔍 Latest deploy log https://app.netlify.com/sites/webkit-speedometer/deploys/679a9d57c3ea0200082d597b
😎 Deploy Preview https://deploy-preview-484--webkit-speedometer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
and also thanks for the well-defined commits, this makes it easier to review!

@rniwa
Copy link
Member

rniwa commented Feb 12, 2025

What's the motivation for merging this fix into 3.1?

@flashdesignory
Copy link
Contributor Author

What's the motivation for merging this fix into 3.1?

It's a "nice to have" low risk cleanup, that doesn't change scores.

@flashdesignory flashdesignory merged commit cdc058a into WebKit:main Feb 25, 2025
8 checks passed
@flashdesignory flashdesignory deleted the release/3.1-428 branch February 25, 2025 17:35
@flashdesignory flashdesignory restored the release/3.1-428 branch February 25, 2025 17:36
@lingyuncai
Copy link

Hi, I noticed this PR merge on the main branch while syncing the ToT code. Should this PR be merged into the release/3.1 branch, according to the description and labels added?

@rniwa
Copy link
Member

rniwa commented Feb 26, 2025

oh yeah, looks like we merged into a wrong branch.

@flashdesignory
Copy link
Contributor Author

oh yeah, looks like we merged into a wrong branch.

🤦 - I will open a new pr to merge into the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants