ComplexTextController: Avoid unsafe forward declaration

[vitorroriz]

1af38de

ComplexTextController: Avoid unsafe forward declaration
rdar://148631147
https://bugs.webkit.org/show_bug.cgi?id=291117

Reviewed by NOBODY (OOPS!).

* Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebCore/platform/graphics/ComplexTextController.h:

1af38de

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 1af38de)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-ews-buildbot]

Safer C++ Build #30674 (1af38de)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

[geoffreygaren]

Looks like there’s a Safer CPP failure.

[vitorroriz]

Looks like there’s a Safer CPP failure.

@geoffreygaren I believe this might be a false positive as we already include WeakHashSet.h which includes WeakPtr.h which defines SingleThreadWeakHashSet.

I wrote @rniwa about it.

[geoffreygaren]

Looks like there’s a Safer CPP failure.

@geoffreygaren I believe this might be a false positive as we already include WeakHashSet.h which includes WeakPtr.h which defines SingleThreadWeakHashSet.

I wrote @rniwa about it.

Makes sense. In the meantime we’ll need to figure out how to keep the bot green despite the false positive.

[rniwa]

@geoffreygaren I believe this might be a false positive as we already include WeakHashSet.h which includes WeakPtr.h which defines SingleThreadWeakHashSet.
I wrote @rniwa about it.

Makes sense. In the meantime we’ll need to figure out how to keep the bot green despite the false positive.

We should probably suppress it for now. Here's a clang PR to fix this issue in the checker: llvm/llvm-project#134545.