Skip to content

[MessageControl] Fix a shutdown issue #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeithMetro merged 2 commits into from
Jul 7, 2025
Merged

[MessageControl] Fix a shutdown issue #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52262d5
Make sure that the Cleanups vector won't get destroyed before the Obs…
VeithMetro Jul 2, 2025
1833c3e
Add the Cleanups vector to the constructor for consistency
VeithMetro Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MessageControl/MessageControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ namespace Thunder {
, _outputDirector()
, _webSocketExporter()
, _callback(nullptr)
, _cleaning()
, _observer(*this)
, _service(nullptr)
, _dispatcherIdentifier(Messaging::MessageUnit::Instance().Identifier())
Expand Down
2 changes: 1 addition & 1 deletion MessageControl/MessageControl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ namespace Plugin {
OutputList _outputDirector;
Publishers::WebSocketOutput _webSocketExporter;
MessageControl::ICollect::ICallback* _callback;
Cleanups _cleaning;
Core::SinkType<Observer> _observer;
PluginHost::IShell* _service;
const string _dispatcherIdentifier;
Expand All @@ -475,7 +476,6 @@ namespace Plugin {
Messaging::TraceFactoryType<Core::Messaging::IStore::WarningReporting, Core::Messaging::TextMessage> _warningReportingFactory;
Messaging::TraceFactoryType<Core::Messaging::IStore::OperationalStream, Core::Messaging::TextMessage> _operationalStreamFactory;
Messaging::TraceFactoryType<Core::Messaging::IStore::Assert, Core::Messaging::TextMessage> _assertFactory;
Cleanups _cleaning;
};

} // namespace Plugin
Expand Down
Loading