[MessageControl] Make sure no messages are missed via the UDP output#362
Merged
[MessageControl] Make sure no messages are missed via the UDP output#362
Conversation
…o never miss messages
pwielders
reviewed
Aug 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the UDP message output mechanism to prevent message loss by replacing a fixed-size buffer approach with a queue-based system. The changes eliminate buffer overflow scenarios where messages could be dropped when the UDP buffer was full.
- Replaced fixed-size UDP buffer with a dynamic queue to handle message bursts
- Modified Channel::Output to use move semantics for better performance
- Optimized string formatting to reduce memory allocations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| MessageControl/MessageOutput.h | Replaced fixed buffer with std::queue and updated Output method signature to use move semantics |
| MessageControl/MessageOutput.cpp | Implemented queue-based message handling and optimized string formatting operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@pwielders take a look at the changes I made in |
Contributor
|
@VeithMetro the Convert looksgood, I could not make it more performant! (y) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pwielders if we decide to move with my solution, what value for ProxyPoolTypeSize you think would be best?
I suppose we don't want the initial ProxyTypePool size to be too big, but on the other hand, the messages are mostly missed at the start when there are a lot of them...