Skip to content

Add const to type in Unregister methods #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nxtum wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add const to type in Unregister methods #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DisplayInfo/DeviceSettings/PlatformImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class DisplayInfoImplementation :

return (Core::ERROR_NONE);
}
uint32_t Unregister(INotification* notification) override
uint32_t Unregister(const INotification* notification) override
{
ASSERT(notification != nullptr);

Expand Down
2 changes: 1 addition & 1 deletion DisplayInfo/Linux/PlatformImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ namespace Plugin {
return (Core::ERROR_NONE);
}

uint32_t Unregister(IConnectionProperties::INotification* notification) override
uint32_t Unregister(const IConnectionProperties::INotification* notification) override
{
std::lock_guard<std::mutex> lock(_observersLock);

Expand Down
2 changes: 1 addition & 1 deletion DisplayInfo/RPI/PlatformImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class DisplayInfoImplementation : public Exchange::IHDRProperties,

return (Core::ERROR_NONE);
}
uint32_t Unregister(INotification* notification) override
uint32_t Unregister(const INotification* notification) override
{
ASSERT(notification != nullptr);

Expand Down
2 changes: 1 addition & 1 deletion LocationSync/LocationSync.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ POP_WARNING()
return Core::ERROR_NONE;
}

uint32_t LocationSync::Unregister(Exchange::ITimeZone::INotification* sink) {
uint32_t LocationSync::Unregister(const Exchange::ITimeZone::INotification* sink) {
_adminLock.Lock();
TimeZoneObservers::iterator index = std::find(_timezoneoberservers.begin(), _timezoneoberservers.end(), sink);
ASSERT (index != _timezoneoberservers.end());
Expand Down
2 changes: 1 addition & 1 deletion LocationSync/LocationSync.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ POP_WARNING()
// ITimeZone methods
// -------------------------------------------------------------------------------------------------------
uint32_t Register(ITimeZone::INotification* sink) override;
uint32_t Unregister(ITimeZone::INotification* sink) override;
uint32_t Unregister(const ITimeZone::INotification* sink) override;
uint32_t TimeZone(string& timeZone ) const override;
uint32_t TimeZone(const string& timeZone) override;

Expand Down
2 changes: 1 addition & 1 deletion PlayerInfo/DeviceSettings/PlatformImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ class PlayerInfoImplementation : public Exchange::IPlayerProperties, public Exch
return (Core::ERROR_NONE);
}

uint32_t Unregister(Exchange::Dolby::IOutput::INotification* notification) override
uint32_t Unregister(const Exchange::Dolby::IOutput::INotification* notification) override
{
ASSERT(notification != nullptr);

Expand Down
2 changes: 1 addition & 1 deletion PlayerInfo/Dolby/DolbyOutput.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ namespace Thunder

return (Core::ERROR_NONE);
}
uint32_t Unregister(Exchange::Dolby::IOutput::INotification* notification) override
uint32_t Unregister(const Exchange::Dolby::IOutput::INotification* notification) override
{
ASSERT(notification != nullptr);

Expand Down
8 changes: 4 additions & 4 deletions WebKitBrowser/WebKitImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ namespace Plugin {
_adminLock.Unlock();
}

void Unregister(Exchange::IBrowserCookieJar::INotification* sink) override
void Unregister(const Exchange::IBrowserCookieJar::INotification* sink) override
{
ASSERT(sink != nullptr);
_adminLock.Lock();
Expand Down Expand Up @@ -1414,7 +1414,7 @@ namespace Plugin {

}

void Unregister(Exchange::IWebBrowser::INotification* sink) override
void Unregister(const Exchange::IWebBrowser::INotification* sink) override
{
ASSERT(sink != nullptr);

Expand Down Expand Up @@ -1455,7 +1455,7 @@ namespace Plugin {
TRACE(Trace::Information, (_T("Registered a sink on the browser %p"), sink));
}

void Unregister(Exchange::IBrowser::INotification* sink) override
void Unregister(const Exchange::IBrowser::INotification* sink) override
{
ASSERT(sink != nullptr);

Expand Down Expand Up @@ -1497,7 +1497,7 @@ namespace Plugin {
_adminLock.Unlock();
}

void Unregister(Exchange::IApplication::INotification* sink) override
void Unregister(const Exchange::IApplication::INotification* sink) override
{
ASSERT(sink != nullptr);

Expand Down
Loading