Skip to content

Fix Thing names in rules engine UI - closes #3183 #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfrancis merged 1 commit into from
Dec 17, 2025
Merged

Fix Thing names in rules engine UI - closes #3183 #3229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions static/js/rules/RuleUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,16 @@ const RuleUtils = {
console.warn('byProperty property undefined', new Error().stack);
return false;
}

const propHref = `/things/${encodeURIComponent(property.thing)}/properties/${encodeURIComponent(
property.id
)}`;
const optProp = option.properties[property.id];
return optProp && optProp.forms && optProp.forms.length;
return (
optProp &&
optProp.forms.filter((f) => {
return f.href === propHref;
}).length > 0
);
},
// Helper function for selecting the thing corresponding to an href
byThing: (thing) => (otherThing) => {
Expand Down