Verbose flag on methods that console.log #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itch logging on/off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a verbose boolean flag (defaulting to false) on all methods console.log'ing as lib was spamming console whenever any change happened. For instances where lots of communication happens with lots of data this would lead to some lag and frustration debugging.
This might be better done as a global flag, I did function specific args for now as I needed a fork that didn't spam console.
For
event-listener.tsI added the flag to theEventListenerOptionsstruct.I tried to keep your code style and added comments / info where appropriate.
Thanks!